Tom, > Some devices may not be decent enough to report lbpme bit properly > even when they do support unmap and report relevant information in the > block limits and logical block provisioning VPDs properly (Namely, > ASMedia ASM1351, a UAS-SATA bridge). One of the reasons is, lbpme=1 is > not a requirement for "DeleteNotify" in Windows to be activated: I have to confess I'm wary of interpreting values reported by a device that messes up setting the single bit flag that enables the feature. Before I entertain taking your patch I'd like to take a closer look to make sure everything is gated by sdkp->lbpme. However, instead of relying on UNMAP, does this bridge support WRITE SAME with the UNMAP bit? Because in that case you should be able to set provisioning_mode to WS10 or WS16 and then adjust max_write_same_blocks. -- Martin K. Petersen Oracle Linux Engineering
