On 16/08/17 06:18, Christophe JAILLET wrote:
'rc' is known to be 0 at this point.
If 'create_context()' fails, returns -ENOMEM instead of 0 which means
success.
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
ENOMEM seems right here.
Reviewed-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>
---
drivers/scsi/cxlflash/superpipe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/cxlflash/superpipe.c b/drivers/scsi/cxlflash/superpipe.c
index ad0f9968ccfb..08da593cb2f6 100644
--- a/drivers/scsi/cxlflash/superpipe.c
+++ b/drivers/scsi/cxlflash/superpipe.c
@@ -1390,6 +1390,7 @@ static int cxlflash_disk_attach(struct scsi_device *sdev,
if (unlikely(!ctxi)) {
dev_err(dev, "%s: Failed to create context ctxid=%d\n",
__func__, ctxid);
+ rc = -ENOMEM;
goto err;
}
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx IBM Australia Limited
