Hannes, > + name = sdev_bflags_name(bflags); > + if (name) > + blen = snprintf(ptr, strlen(name) + 1, > + "%s", name); > + else > + blen = snprintf(ptr, 67, "0x%X", bflags); It seems this else statement facilitates papering over the fact that scsi_sysfs.c and scsi_devinfo.h can get out of sync. -- Martin K. Petersen Oracle Linux Engineering