On 08/09/2017 03:40 PM, Christoph Hellwig wrote: > These seem to be modified from sysfs files, so you'll run into > read-modify-write atomicy issues with bitfields. > > That being said while plain ints are somewhat safe the right thing > would be to use proper atomic bitops. > True, but rewriting that into atomics would change the flow of the driver by quite a bit (as quite some spinlocks can be removed), so I'd rather _not_ attempt this now. So I'll be dropping this patch. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
