>-----Original Message----- >From: Tomas Henzl [mailto:thenzl@xxxxxxxxxx] >Sent: Friday, July 28, 2017 7:34 PM >To: linux-scsi@xxxxxxxxxxxxxxx >Cc: sumit.saxena@xxxxxxxxxxxx; kashyap.desai@xxxxxxxxxxxx >Subject: [PATCH] megaraid_sas: move command counter to correct place > >the eh reset function returns success when fw_outstanding equals zero, that >means that the counter shouldn't be decremented when the driver still owns >the command > > >Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx> >--- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c >b/drivers/scsi/megaraid/megaraid_sas_fusion.c >index f990ab4d45..c615aadb2b 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c >+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c >@@ -3046,7 +3046,6 @@ complete_cmd_fusion(struct megasas_instance >*instance, u32 MSIxIndex) > } > //Fall thru and complete IO > case MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST: /* LD-IO >Path */ >- atomic_dec(&instance->fw_outstanding); > if (cmd_fusion->r1_alt_dev_handle == >MR_DEVHANDLE_INVALID) { > map_cmd_status(fusion, scmd_local, status, > extStatus, >le32_to_cpu(data_length), @@ -3060,6 +3059,7 @@ >complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex) > scmd_local->scsi_done(scmd_local); > } else /* Optimal VD - R1 FP command completion. >*/ > megasas_complete_r1_command(instance, >cmd_fusion); >+ atomic_dec(&instance->fw_outstanding); > break; > case MEGASAS_MPI2_FUNCTION_PASSTHRU_IO_REQUEST: >/*MFI command */ > cmd_mfi = instance->cmd_list[cmd_fusion- >>sync_cmd_idx]; Acked-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx> >-- >2.9.4
