Re: [PATCH v2 13/20] lpfc: Fix MRQ > 1 context list handling

[Johannes Thumshirn <jthumshirn@xxxxxxx>]

On Fri, Aug 04, 2017 at 05:47:24PM -0700, James Smart wrote:
> +				tgtp = (struct lpfc_nvmet_tgtport *)
> +					phba->targetport->private;

Please don't case void pointers.

[...]

> +			list_splice(&get_infop->nvmet_ctx_list,
> +				    &current_infop->nvmet_ctx_list);
> +			INIT_LIST_HEAD(&get_infop->nvmet_ctx_list);

			list_splice_init(&get_infop->nvmet_ctx_list,
					 &current_infop->nvmet_ctx_list);


-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850