On 08/05/2017 01:35 PM, Christoph Hellwig wrote: >> error = scsi_dh_add_device(sdev); >> - if (error) >> - /* >> - * device_handler is optional, so any error can be ignored >> - */ >> - sdev_printk(KERN_INFO, sdev, >> - "failed to add device handler: %d\n", error); >> + /* device_handler is optional, so any error can be ignored */ > > In that case it should return void. > Okay, will be updating the patch. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)