On 07/25/2017 04:14 PM, Steffen Maier wrote: > Do not get scsi_device via req->data any more, but pass an optional(!) > scsi_device to zfcp_fsf_fcp_handler_common(). The latter must now guard > any access to scsi_device as it can be NULL. > > Since we always have at least a zfcp port as scope, pass this as mandatory > argument to zfcp_fsf_fcp_handler_common() because we cannot get it through > scsi_device => zfcp_scsi_dev => port any more. > > Hence, the callers of zfcp_fsf_fcp_handler_common() must resolve req->data. > > TMF handling now has different context data in fsf_req->data > depending on the TMF scope in fcp_cmnd->fc_tm_flags: > * scsi_device if FCP_TMF_LUN_RESET, > * zfcp_port if FCP_TMF_TGT_RESET. > > Signed-off-by: Steffen Maier <maier@xxxxxxxxxxxxxxxxxx> > --- > drivers/s390/scsi/zfcp_fsf.c | 72 ++++++++++++++++++++++++++++---------------- > 1 file changed, 46 insertions(+), 26 deletions(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
