On Tue, 2017-07-25 at 23:40 +0800, kbuild test robot wrote: > drivers/scsi/megaraid/megaraid_sas_fusion.c:608:2-18: WARNING: NULL > check before freeing functions like kfree, debugfs_remove, > debugfs_remove_recursive or usb_free_urb is not needed. Maybe > consider reorganizing relevant code to avoid passing NULL values. > drivers/scsi/megaraid/megaraid_sas_fusion.c:629:2-18: WARNING: NULL > check before freeing functions like kfree, debugfs_remove, > debugfs_remove_recursive or usb_free_urb is not needed. Maybe > consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. Hey, guys, we yelled at Markus Elfring for sending hundreds of patches like this. The reason then was too much code churn for too little value: the if() might be unnecessary but it really doesn't cost very much in terms of execution time, so the code churn disadvantage greatly outweighs any benefits. The reason hasn't changed, so please stop this otherwise you're going to turn the very valuable 0day test infrastructure into a thousand patch spambot. James
