Hi Elliott, We are maintaining NVMe drives as scsi device in mpt3sas driver. There are lot of firmware/hardware level dependencies and after lot of discussions we arrived this value (128). So, we prefer not to provide module parameter to change this at least for now. Thanks, Suganath Prabu S On Tue, Jul 11, 2017 at 10:53 PM, Elliott, Robert (Persistent Memory) <elliott@xxxxxxx> wrote: >> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h >> @@ -115,7 +115,7 @@ >> >> #define MPT3SAS_RAID_MAX_SECTORS 8192 >> #define MPT3SAS_HOST_PAGE_SIZE_4K 12 >> - >> +#define MPT3SAS_NVME_QUEUE_DEPTH 128 > ... >> + /*TODO-right Queue Depth?*/ >> + qdepth = MPT3SAS_NVME_QUEUE_DEPTH; >> + ds = "NVMe"; > > The native NVMe driver is getting a modparam to set that value (rather than > using a #define of 1024) in this patch: > http://lists.infradead.org/pipermail/linux-nvme/2017-July/011734.html > > Perhaps this driver should do the same. > > --- > Robert Elliott, HPE Persistent Memory > >
