On Wed, Jul 12, 2017 at 03:35:34PM -0700, Song Liu wrote: > + if (!test_bit(sshdr->sense_key & 0xf, > + &sdev->sense_event_filter)) While being technically correct, this looks a bit kludgy. Please pass in the whole sense_key without masking it. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850