在 2017/7/11 23:54, John Garry 写道: > On 10/07/2017 08:06, Yijing Wang wrote: >> No one uses the port_gone_completion in struct asd_sas_port, >> clean it out. > > This seems like a reasonable tidy-up patch which could be taken in isolation, having no dependency on the rest of the series. Yes. > >> >> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx> >> --- >> include/scsi/libsas.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h >> index c41328d..628f48b 100644 >> --- a/include/scsi/libsas.h >> +++ b/include/scsi/libsas.h >> @@ -263,8 +263,6 @@ struct sas_discovery { >> /* The port struct is Class:RW, driver:RO */ >> struct asd_sas_port { >> /* private: */ >> - struct completion port_gone_completion; >> - >> struct sas_discovery disc; >> struct domain_device *port_dev; >> spinlock_t dev_list_lock; >> > > > > . >