On Mon, Jul 24, 2006 at 10:27:55AM -0700, Tony Luck wrote: > On 6/3/06, Christoph Hellwig <hch@xxxxxx> wrote: > >Currently struct scsi_cmnd has various fields that are used to backup > >original data after the corresponding fields have been overridden for > >EH commands. This means drivers can easily get at it and misuse it. > >Due to the old_ naming this doesn't happen for most of them, but two > >that have different names have been used wrong a lot (see previous > >patch). > > I guess that I'm an abuser :-( > > >Index: scsi-misc-2.6/include/scsi/scsi_cmnd.h > > >- void *buffer; /* Data buffer */ > > arch/ia64/hp/sim/simscsi.c is still using this (and so doesn't compile > now that this change has hit mainline). It seems that simscsi.c is > expecting to find a "scatterlist" there ... but looking at the rest of > the patch that removed this element, it isn't obvious where it went. Just change it to access the request_buffer member instead. buffer and request_buffer have been synonymous 99% of the time, and a driver never even wants to access buffer. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
