>-----Original Message----- >From: Hannes Reinecke [mailto:hare@xxxxxxx] >Sent: Thursday, June 29, 2017 11:23 AM >To: Kashyap Desai; Sumit Saxena; Christoph Hellwig >Cc: Martin K. Petersen; James Bottomley; linux-scsi@xxxxxxxxxxxxxxx; Hannes >Reinecke >Subject: Re: [PATCH 13/47] megaraid: pass in NULL scb for host reset > >On 06/28/2017 07:40 PM, Kashyap Desai wrote: >>> -----Original Message----- >>> From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- >>> owner@xxxxxxxxxxxxxxx] On Behalf Of Hannes Reinecke >>> Sent: Wednesday, June 28, 2017 9:00 PM >>> To: Sumit Saxena; Christoph Hellwig >>> Cc: Martin K. Petersen; James Bottomley; linux-scsi@xxxxxxxxxxxxxxx; >>> Hannes Reinecke >>> Subject: Re: [PATCH 13/47] megaraid: pass in NULL scb for host reset >>> >>> On 06/28/2017 03:41 PM, Sumit Saxena wrote: >>>>> -----Original Message----- >>>>> From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- >>>>> owner@xxxxxxxxxxxxxxx] On Behalf Of Hannes Reinecke >>>>> Sent: Wednesday, June 28, 2017 2:03 PM >>>>> To: Christoph Hellwig >>>>> Cc: Martin K. Petersen; James Bottomley; >>>>> linux-scsi@xxxxxxxxxxxxxxx; >>>> Hannes >>>>> Reinecke; Hannes Reinecke >>>>> Subject: [PATCH 13/47] megaraid: pass in NULL scb for host reset >>>>> >>>>> When calling a host reset we shouldn't rely on the command >>>>> triggering the reset, so allow megaraid_abort_and_reset() to be >>>>> called with a NULL >>> scb. >>>>> And drop the pointless 'bus_reset' and 'target_reset' handlers, >>>>> which >>>> just call >>>>> the same function as host_reset. >>>> >>>> If this patch address any functional issue, then we should consider >>>> this. >>>> If it's code optimization, can we ignore this as this is being very >>>> old driver and no more maintained by Broadcom/LSI ? >>>> >>> Sadly, ignoring is not an option. >>> I'm planning to update the calling convention for SCSI EH, to resolve >>> the >>> long- >>> standing problem with sg_reset ioctls. >>> sg_reset ioctl will allocate an out-of-band SCSI command, which does >>> no longer work with the new command allocation scheme in multiqueue. >>> So it's not possible to just 'ignore' it, as then SCSI EH will cease >>> to function with that driver. >> >> Hannes - We are in process of sending megaraid and 3ware driver >> removal as LSI/Broadcom stopped supporting those products. >> I agree we should review this closely, but lack of test coverage and >> end of life cycle of product is requesting us to know the rational. >> For now, let's consider NACK for this patch. We will be removing old >> megaraid (mbox) driver and 3Ware drivers soon. >> >Hmm. >Can't we do the removal now? >There is not a lot of testing involved with _that_, surely? > >I'd be happy to do a patch if you like ... We are fine with you submitting the patch to remove megaraid and megaraid_mm drivers. 3ware drivers are maintained by Adam Radford so we can not remove them. > >Cheers, > >Hannes >-- >Dr. Hannes Reinecke Teamlead Storage & Networking >hare@xxxxxxx +49 911 74053 688 >SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg >GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 >(AG Nürnberg)
