Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Johannes Thumshirn <jthumshirn@xxxxxxx>
Subject: Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Tue, 27 Jun 2017 21:32:02 -0400
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Linux SCSI Mailinglist <linux-scsi@xxxxxxxxxxxxxxx>, Linux Kernel Mailinglist <linux-kernel@xxxxxxxxxxxxxxx>, qla2xxx-upstream@xxxxxxxxxx, Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, John Garry <john.garry@xxxxxxxxxx>
In-reply-to: <20170623071011.21184-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Fri, 23 Jun 2017 09:10:11 +0200")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

> In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
> qpair->qp_lock but do access members of the qpair before having the lock.
> Re-order the locking sequence to have all read and write access to qpair
> members under the qpair->qp_lock.

Cavium folks, please review!

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
  - From: Madhani, Himanshu

References:
- [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
  - From: Johannes Thumshirn

Prev by Date: Re: [PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware
Next by Date: Re: [PATCH] scsi: ufs: set host_byte to DID_REQUEUE when ocs = OCS_ABORTED
Previous by thread: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
Next by thread: Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]