On Fri, Jun 23, 2017 at 03:02:55PM +0200, Hannes Reinecke wrote: > As we now have moved the error handler functions to not rely on > a scsi command we can drop the out-of-band scsi command allocation > from scsi_ioctl_reset(). > > Signed-off-by: Hannes Reinecke <hare@xxxxxxxx> > --- > drivers/scsi/scsi_error.c | 112 +++++++++++++++++----------------------------- > 1 file changed, 42 insertions(+), 70 deletions(-) > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index 4a7fe97f..c9bd7a4 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -728,16 +728,22 @@ static void scsi_eh_done(struct scsi_cmnd *scmd) > complete(eh_action); > } > > +static void __scsi_report_device_reset(struct scsi_device *sdev, void *data) > +{ > + sdev->was_reset = 1; > + sdev->expecting_cc_ua = 1; > +} Please have aversion without the data argument, which is only needed for the target iterator.