Re: [PATCH 22/35] scsi: Use Scsi_Host as argument for eh_host_reset_handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hannes,

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on next-20170623]
[cannot apply to v4.12-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hannes-Reinecke/SCSI-EH-argument-reshuffling/20170624-071433
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:13,
                    from include/linux/delay.h:21,
                    from drivers/scsi/cxlflash/main.c:15:
   drivers/scsi/cxlflash/main.c: In function 'cxlflash_eh_host_reset_handler':
>> drivers/scsi/cxlflash/main.c:2186:15: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'unsigned int' [-Wformat=]
     dev_dbg(dev, "%s: %d/-1/-1/-1\n", host->host_no);
                  ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
>> drivers/scsi/cxlflash/main.c:2186:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(dev, "%s: %d/-1/-1/-1\n", host->host_no);
     ^~~~~~~
>> drivers/scsi/cxlflash/main.c:2186:15: warning: format '%d' expects a matching 'int' argument [-Wformat=]
     dev_dbg(dev, "%s: %d/-1/-1/-1\n", host->host_no);
                  ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
>> drivers/scsi/cxlflash/main.c:2186:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(dev, "%s: %d/-1/-1/-1\n", host->host_no);
     ^~~~~~~

vim +2186 drivers/scsi/cxlflash/main.c

  2170	 * Following a reset, the state is evaluated again in case an EEH occurred
  2171	 * during the reset. In such a scenario, the host reset will either yield
  2172	 * until the EEH recovery is complete or return success or failure based
  2173	 * upon the current device state.
  2174	 *
  2175	 * Return:
  2176	 *	SUCCESS as defined in scsi/scsi.h
  2177	 *	FAILED as defined in scsi/scsi.h
  2178	 */
  2179	static int cxlflash_eh_host_reset_handler(struct Scsi_Host *host)
  2180	{
  2181		int rc = SUCCESS;
  2182		int rcr = 0;
  2183		struct cxlflash_cfg *cfg = shost_priv(host);
  2184		struct device *dev = &cfg->dev->dev;
  2185	
> 2186		dev_dbg(dev, "%s: %d/-1/-1/-1\n", host->host_no);
  2187	
  2188		switch (cfg->state) {
  2189		case STATE_NORMAL:
  2190			cfg->state = STATE_RESET;
  2191			drain_ioctls(cfg);
  2192			cxlflash_mark_contexts_error(cfg);
  2193			rcr = afu_reset(cfg);
  2194			if (rcr) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux