Yes, it¹s needed. We will post a patch. On 6/23/17, 9:34 AM, "Julia Lawall" <julia.lawall@xxxxxxx> wrote: >Please check on whether an unlock is neeed before line 1965. > >julia > >---------- Forwarded message ---------- >Date: Fri, 23 Jun 2017 15:23:00 +0800 >From: kbuild test robot <fengguang.wu@xxxxxxxxx> >To: kbuild@xxxxxx >Cc: Julia Lawall <julia.lawall@xxxxxxx> >Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with > qpair->qp_lock > >CC: kbuild-all@xxxxxx >In-Reply-To: <20170622134325.26931-1-jthumshirn@xxxxxxx> > >Hi Johannes, > >[auto build test WARNING on scsi/for-next] >[also build test WARNING on v4.12-rc6 next-20170622] >[if your patch is applied to the wrong git tree, please drop us a note to >help improve the system] > >url: >https://github.com/0day-ci/linux/commits/Johannes-Thumshirn/qla2xxx-Protec >t-access-to-qpair-members-with-qpair-qp_lock/20170623-123844 >base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git >for-next >:::::: branch date: 3 hours ago >:::::: commit date: 3 hours ago > >>> drivers/scsi/qla2xxx/qla_iocb.c:1965:3-9: preceding lock on line 1952 > >git remote add linux-review https://github.com/0day-ci/linux >git remote update linux-review >git checkout 4a35d720268dbe9ac016957a3c4fc644398d68ba >vim +1965 drivers/scsi/qla2xxx/qla_iocb.c > >d74595278 Michael Hernandez 2016-12-12 1946 /* Only process >protection or >16 cdb in this routine */ >d74595278 Michael Hernandez 2016-12-12 1947 if (scsi_get_prot_op(cmd) >== SCSI_PROT_NORMAL) { >d74595278 Michael Hernandez 2016-12-12 1948 if (cmd->cmd_len <= 16) >d74595278 Michael Hernandez 2016-12-12 1949 return >qla2xxx_start_scsi_mq(sp); >d74595278 Michael Hernandez 2016-12-12 1950 } >d74595278 Michael Hernandez 2016-12-12 1951 >4a35d7202 Johannes Thumshirn 2017-06-22 @1952 > spin_lock_irqsave(&qpair->qp_lock, flags); >4a35d7202 Johannes Thumshirn 2017-06-22 1953 >d74595278 Michael Hernandez 2016-12-12 1954 /* Setup qpair pointers */ >d74595278 Michael Hernandez 2016-12-12 1955 rsp = qpair->rsp; >d74595278 Michael Hernandez 2016-12-12 1956 req = qpair->req; >d74595278 Michael Hernandez 2016-12-12 1957 >d74595278 Michael Hernandez 2016-12-12 1958 /* So we know we haven't >pci_map'ed anything yet */ >d74595278 Michael Hernandez 2016-12-12 1959 tot_dsds = 0; >d74595278 Michael Hernandez 2016-12-12 1960 >d74595278 Michael Hernandez 2016-12-12 1961 /* Send marker if >required */ >d74595278 Michael Hernandez 2016-12-12 1962 if (vha->marker_needed != >0) { >d74595278 Michael Hernandez 2016-12-12 1963 if (qla2x00_marker(vha, >req, rsp, 0, 0, MK_SYNC_ALL) != >d74595278 Michael Hernandez 2016-12-12 1964 QLA_SUCCESS) >d74595278 Michael Hernandez 2016-12-12 @1965 return >QLA_FUNCTION_FAILED; >d74595278 Michael Hernandez 2016-12-12 1966 vha->marker_needed = 0; >d74595278 Michael Hernandez 2016-12-12 1967 } >d74595278 Michael Hernandez 2016-12-12 1968 > >:::::: The code at line 1965 was first introduced by commit >:::::: d74595278f4ab192af66d9e60a9087464638beee scsi: qla2xxx: Add >multiple queue pair functionality. > >:::::: TO: Michael Hernandez <michael.hernandez@xxxxxxxxxx> >:::::: CC: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > >--- >0-DAY kernel test infrastructure Open Source Technology >Center >https://lists.01.org/pipermail/kbuild-all Intel >Corporation
