On Fri, 2017-06-23 at 15:02 +0200, Hannes Reinecke wrote: > zfcp_task_mgmt_function() is only used for lun and device reset, > so it should be using the scsi device as an argument, not the > scsi command. There are multiple changes in this patch which makes this patch harder to review than necessary. Please split this patch, e.g. as follows: * one patch that removes the "tm_flags" argument from zfcp_fc_scsi_to_fcp() and inlines the tm_flags != 0 case. * another patch that adds the struct scsi_device * argument to zfcp_fsf_fcp_handler_common(). * a third patch that changes the first argument of zfcp_task_mgmt_function() from struct scsi_cmnd * into struct scsi_device *. Thanks, Bart.
