On Fri, Jun 23, 2017 at 04:25:27PM +0100, John Garry wrote: > On 23/06/2017 16:15, Dan Carpenter wrote: > > phy->phy_type is a u64. We only ever use the first two bits so it's a > > bit over kill perhaps. > > Hi Dan, > > Right, u64 is unneeded and u32 would suffice, so I think that would be a > more appropriate fix. And if we change hisi_sas_phy.phy_type to u32, I would > want to reorder this structure to improve packing efficiency. > > I can make this change unless you really want to... > Feel free to make the change. :) regards, dan carpenter
