Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/22/2017 12:41 AM, Johannes Thumshirn wrote:
On Wed, Jun 21, 2017 at 10:37:58AM -0700, James Smart wrote:
[...]
-	/*
-	 * Catch race where our node has transitioned, but the
-	 * transport is still transitioning.
-	 */


The patch looks fine but can you please explain why the above race can't
happen anymore?

Thanks,
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>


well, the primary reason is the code that was removed was bogus to begin with. Abort of an io/exchange, if its active, needs to occur on the link regardless of the ndlp state. This it simply needed to occur. As not checks on ndlp state are needed, there is no race.

-- james




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux