On Fri, Jun 16, 2017 at 03:47:42PM -0700, Himanshu Madhani wrote:
> From: Duane Grigsby <duane.grigsby@xxxxxxxxxx>
>
> This patch adds switch command support for FC-4 type of FC-NVMe (0x28)
> for resgistering HBA port to the management server. RFT_ID command is
> used to register FC-4 type of 0x28 and RFF_ID is used to register
> FC-4 features bits for FC-NVMe port.
>
> Signed-off-by: Darren Trapp <darren.trapp@xxxxxxxxxx>
> Signed-off-by: Duane Grigsby <duane.grigsby@xxxxxxxxxx>
> Signed-off-by: Anil Gurumurthy <anil.gurumurhty@xxxxxxxxxx>
> Signed-off-by: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> ---
[...]
> + ct_rsp = &fcport->ct_desc.ct_sns->p.rsp;
> + /*
> + * FC-GS-7, 5.2.3.12 FC-4 Features - format
> + * The format of the FC-4 Features object, as defined by the FC-4,
> + * Shall be an array of 4-bit values, one for each type code value
> + */
Indentation looks a bit odd here. Did you run checkpatch.pl on the series?
> @@ -4634,6 +4637,12 @@ qla2x00_configure_fabric(scsi_qla_host_t *vha)
> &vha->dpc_flags))
> break;
> }
> + if (vha->flags.nvme_enabled) {
> + if (qla2x00_rff_id(vha, FC4_TYPE_NVME)) {
if (vha->flags.nvme_enabled &&
qla2x00_rff_id(vha, FC4_TYPE_NVME))
ql_dbg(ql_dbg_disc, vha, 0x2049, ....)
> + ql_dbg(ql_dbg_disc, vha, 0x2049,
> + "Register NVME FC Type Features failed.\n");
> + }
> + }
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
