On Mon, Jun 05, 2017 at 06:36:19PM +0000, Bart Van Assche wrote: > > The mpt3sas driver is the only driver that calls scsi_internal_device_block() > > and scsi_internal_device_unblock() from atomic context. Since it's not an option > > to protect the SCSI device state changes with a spinlock I prefer that the > > mpt3sas authors convert the scsi_internal_device_block() calls into > > scsi_target_block() calls. > > Please also note that although this patch series doesn't improve the mpt3sas > driver, it doesn't change its behavior. Yes. And normally we try to get things right. I guess this series is useful enough without fixing everyone up, but adding a FIXME or getting the broadcom folks involved would be even better.
