Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

sorry for dropping the ball, but your repost reminded me.

On Thu, Jun 01, 2017 at 11:36:55AM +0100, John Garry wrote:
> In the command completion code we need to check for abnormal completion due
> to underflow, but ignore it when it occurs in some commands, like inquiry.
> This is why we check for rw command - it is equivalent to !inquiry.
> 
> I'll see if we can change the check to explicitly ignore certain commands
> which complete abnormally with underflow.

In general it should be up to the higher level and not the driver
to detect underflow, and that's how most (hopefully all, but I won't
bet on some older ones) of our drivers operate.

> 
> > What about 32-byte CDs or things like Write Same?
> > 
> 
> You're talking about VARIABLE_LENGTH_CMD (opcode 0x7f) for 32-byte CDs,
> right?

Yes.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux