Re: [PATCH 1/10] mptfusion : Transport Layer Retry support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Moore wrote:
> --  Wednesday, July 12, 2006 9:32 AM, James Bottomley wrote:
> 
> 
>>If I understand what this does correctly, you snoop the 
>>inquiry field in
>>slave configure and then send a vendor specific opcode that the tape
>>understands (in the event that it reports TLR in its PSLU page)?
>>
>>Really, no, this isn't appropriate for code in a driver, 
>>since I assume
>>enabling TLR via this command on these things should be independent of
>>the particular SAS HBA, so it should probably be a transport specific
>>blacklist.
>>
> 
> 
> Response from co-worker that implemented this:
> 
> --
> 
> The reason HP switched from using a standard Mode Page setting to using a vendor unique CDB is due to SCSI protocol problems.
> 
> The primary issue is that with standard Mode Sense and Mode Select commands, these commands are blocked when either the device has reservations against it or if the device is busy.  TLR needs to be enabled when the device is discovered, which is done using an Inquiry command.  But, let's look at this example:
> 
> The tape cartridge was read previously then the drive turned off (so the tape device is removed from the SAS domain and all device objects are deleted).  Later on, the tape drive is turned back on.  It will be discovered and an event sent to the host driver.  This will kick off an enumeration (Inquiry commands).  With the Inquiry, we detect that this is an HP SAS tape drive and TLR needs to be enabled.  The host driver then sends a Mode Sense to read the SAS protocol page so we can enable TLR.  However, the tape cartridge is rewinding.  The Inquriy commands completed because they are "immediate" commands that the drive can service at any time.  But, the Mode Sense (and Mode Select) commands are blocked (pended) while the tape drive is busy.  I can take more than 5 minutes for a tape cartridge to rewind and become ready, at which time the Mode Sense would be completed.  It isn't that the Mode Sense is returned with Busy, it is pended so it remains outstanding and no other co
mmands can be sent to the drive.
> 
> A similar problem occurs with reservations.  The Inquiry will always complete no matter who has reservations on the drive.  But, a Mode Sense (and Mode Select) will fail if another initiator has reservations.
> 
> I found the long Busy problem (just because the drive takes up to and even longer than 30 seconds to come Ready after a power on, no matter where the tape is).  I was trying to piggy-back on the OS Inquiry command (which has a timeout of 4 seconds) and this was failing.  I modified my driver to perform the Mode Sense outside of the OS Inquiry command, but HP came back with the above scenarios (tape rewind and reservations) and that's when they wanted to switch to a vendor-unique CDB (much easier for them F/W wise).
> 
> The usage of Mode Sense and Mode Select will still work with the HP tape drives, if you can find a way around the above issues.  But I would suggest discussing any solution with the HP-Bristol tape drive folks.

Eric,
Slightly off topic but this reminded me of the LOG SENSE
behaviour I have noticed with a SAS ST336754SS disk.
When the disk is spun down all requests for log pages
apart from the protocol specific port log page (0x18)
fail with a sense key of NOT READY. The protocol specific
port log page works irrespective of the power condition
state. Strangely Seagate reject the port specific _mode_
pages (0x18 and 0x19) when the disk is spun down.

I can't see anything in SPC-4 or SBC-3 that says MODE
SENSE/SELECT and LOG SENSE/SELECT shall not work if
the power condition state is STOPPED. Transport related
mode and log pages are good examples of why the power
condition state should be ignored.

The unit attention delivery and reservations are thorny issues.
Perhaps the HP-Bristol tape drive folks should be talking
to Rob Elliott (also from HP) who is the SAS t10 techical editor.

Doug Gilbert

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux