> +#define PCI_CLASS_STORAGE_UFSHCI 0x010901 should me move to pci_ids.h > + > +#define UFSHCD_INTEL_PCI_UFSHCI_DEVICE() { \ > + .vendor = PCI_VENDOR_ID_INTEL, \ > + .device = PCI_ANY_ID, \ > + .subvendor = PCI_ANY_ID, \ > + .subdevice = PCI_ANY_ID, \ > + .class = PCI_CLASS_STORAGE_UFSHCI, \ > + .class_mask = ~0, \ > +} Please don't use a macro for this. And matching for any possible future intel device with the classcode looks a little sketchy to me to be honest.