On 01/06/2017 06:41, Christoph Hellwig wrote:
> +static int interrupt_init_v3_hw(struct hisi_hba *hisi_hba)
> +{
> + struct device *dev = hisi_hba->dev;
> + struct pci_dev *pdev = hisi_hba->pci_dev;
> + int vectors, i, irq, rc;
> + int max_msi = HISI_SAS_MSI_COUNT_V3_HW;
> + int msi_vectors[HISI_SAS_MSI_COUNT_V3_HW];
> +
> + if (pdev->msi_enabled)
> + pci_disable_msi(pdev);
How could MSIs be enabled at init time? Even if so you should use
pci_free_irq_vectors.
Right, I don't think it could, so this can be removed.
> + for (i = 0; i < vectors; i++)
> + msi_vectors[i] = pdev->irq + i;
You should not need this array, just use pci_irq_vectors().
That should be ok.
.
Thanks,
John
