Re: [PATCH v2 4/5] tcmu: Make dev_config configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bryant,

[auto build test ERROR on target/master]
[also build test ERROR on v4.12-rc3 next-20170530]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bryant-G-Ly/TCMU-Enable-Reconfiguration-Patches/20170531-062328
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
config: i386-randconfig-x005-201722 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers//target/target_core_user.c: In function 'tcmu_dev_path_store':
>> drivers//target/target_core_user.c:1571:3: error: implicit declaration of function 'kree' [-Werror=implicit-function-declaration]
      kree(copy);
      ^~~~
   cc1: some warnings being treated as errors

vim +/kree +1571 drivers//target/target_core_user.c

  1555		struct tcmu_dev *udev = TCMU_DEV(da->da_dev);
  1556	
  1557		return snprintf(page, PAGE_SIZE, "%s\n", udev->dev_config);
  1558	}
  1559	
  1560	static ssize_t tcmu_dev_path_store(struct config_item *item, const char *page,
  1561					   size_t count)
  1562	{
  1563		struct se_dev_attrib *da = container_of(to_config_group(item),
  1564							struct se_dev_attrib, da_group);
  1565		struct tcmu_dev *udev = TCMU_DEV(da->da_dev);
  1566		char *copy = NULL;
  1567		int ret;
  1568	
  1569		copy = kstrdup(page, GFP_KERNEL);
  1570		if (!copy) {
> 1571			kree(copy);
  1572			return -EINVAL;
  1573		}
  1574		strcpy(udev->dev_config, copy);
  1575	
  1576		/* Check if device has been configured before */
  1577		if (tcmu_dev_configured(udev)) {
  1578			ret = tcmu_netlink_event(TCMU_CMD_RECONFIG_DEVICE,
  1579						 udev->uio_info.name,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux