RE: [PATCH] mptsas : reserving a channel for integrated raid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-- Tuesday, July 11, 2006 1:11 PM, James Bottomley wrote: 

> > This patch moves the reserved channel to -1. This can be
> > easily changed to some other value in the future release
> > since its a hash define.
> 
> I don't think -1 showing up in the channel field is a good idea ... I
> bet it will confuse parsers of that information.
> 

agreed.  It was merely a work around that didn't require transport
change.

> > Its higly doubtfull the transport layer would ever
> > use up all the port ids, and wrap back around to zero since
> > this is int.
> 
> Do we still need this channel number as port number stuff anyway?

no

> Originally it was the outgoing phy that was identified in the channel,
> but even that's no longer true.  Since the target ids are assigned per
> HBA, they're unique enough without requiring additional channel
> stuff ... how about killing the non zero channel in the sas transport
> class and then you can simply use 1 for the raid virtual channel?
> 

Correct, originally it was phy_id, then I changed it to port_id.

I'll work in it this afternoon, trying to getting something out later
today.

Eric

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux