Re: [PATCH 10/15] qedf: Add non-offload receive filters.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-05-23 at 06:19 -0700, Dupuis, Chad wrote:
> +	if (ntoh24(&dest_mac[3]) != ntoh24(fh->fh_d_id)) {
> +		QEDF_ERR(&(qedf->dbg_ctx), "FC frame d_id mismatch with MAC "
> +		    "%pM.\n", dest_mac);
> [ ... ]
> +			QEDF_ERR(&(qedf->dbg_ctx), "Wrong source address: "
> +			    "mac:%pM dest_addr:%pM.\n", mac,
> +			    qedf->ctlr.dest_addr);

Hello Chad,

Are you aware that the 80 column limit does not hold for error messages
and that the recommended style is to keep these on a single line?

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux