Re: aic94xx panic on module insertion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2006-07-10 at 10:29 -0700, Mike Anderson wrote:
> Yes, since we have not formed a port yet on phy1 it would appear that we
> could just drop this event if port is null as we are going to do discovery
> post port forming the port anyway.

OK, so this is the fix?

James

diff --git a/drivers/scsi/sas/sas_port.c b/drivers/scsi/sas/sas_port.c
index 07415e9..d931478 100644
--- a/drivers/scsi/sas/sas_port.c
+++ b/drivers/scsi/sas/sas_port.c
@@ -199,6 +199,12 @@ void sas_porte_broadcast_rcvd(void *data
 	u32 prim;
 	struct asd_sas_phy *phy = data;
 
+	/* Broadcast received before port forms.  This is fine, since
+	 * port formation will trigger a domain discovery (rather than
+	 * revalidation) */
+	if (!sas->port)
+		return;
+
 	sas_begin_event(PORTE_BROADCAST_RCVD, &phy->ha->event_lock,
 			&phy->port_events_pending);
 


-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux