On Wed, May 17, 2017 at 12:49 PM, John Garry <john.garry@xxxxxxxxxx> wrote: > Add the code to initialise controller which is based on pci device > in hisi_sas_pci_init.c > > The main functionality added is for probing and initialisation of > the controller based on pci device. > > The core controller routines are still in hisi_sas_main.c; some > common initialisation functions and structures are also exported from > hisi_sas_main.c for pci init. > > For platform device-based controller, controller properties - like > phy count - were read from the firmware. For pci-based controller this > information is hard-coded in the driver, in new struct hisi_sas_pci_hw. > Do you plan to add further PCI based front-ends besides the v3 driver in the future? If not, you can save one level of indirection here and merge pci_init.c into the v3 implementation. Arnd