If the list search in sg_get_rq_mark() fails to find a valid request, we return a bogus element. This then can later lead to a GPF in sg_remove_scat(). So don't return bogus Sg_requests in sg_get_rq_mark() but NULL in case the list search doesn't find a valid request. Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx> Reported-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> Cc: Hannes Reinecke <hare@xxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Cc: Doug Gilbert <dgilbert@xxxxxxxxxxxx> --- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 0a38ba01b7b4..abfde23fa186 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -2078,7 +2078,7 @@ sg_get_rq_mark(Sg_fd * sfp, int pack_id) } } write_unlock_irqrestore(&sfp->rq_list_lock, iflags); - return resp; + return (resp->done == 2) ? resp : NULL; } /* always adds to end of list */ -- 2.12.0
