On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > Sebastian, > > > Martin, do you see any chance to get this merged? Chad replied to the > > list that he is going to test it on 2017-04-10, didn't respond to the > > ping 10 days later. The series stalled last time in the same way. > > I am very reluctant to merge something when a driver has an active > maintainer and that person has not acked the change. > > That said, Chad: You have been sitting on this for quite a while. Please > make it a priority. In exchange for veto rights you do have to provide > timely feedback on anything that touches your driver. > > Thanks! > We did do some testing and hit a calltrace during device discovery: [ 1332.551799] INFO: task scsi_eh_15:1970 blocked for more than 120 seconds. [ 1332.551804] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 1332.551807] scsi_eh_15 D ffff880823488c14 0 1970 2 0x00000080 [ 1332.551813] ffff881053a17cb0 0000000000000046 ffff88084d693ec0 ffff881053a17fd8 [ 1332.551817] ffff881053a17fd8 ffff881053a17fd8 ffff88084d693ec0 ffff880823488d48 [ 1332.551821] ffff880823488d50 7fffffffffffffff ffff88084d693ec0 ffff880823488c14 [ 1332.551825] Call Trace: [ 1332.551838] [<ffffffff8168b579>] schedule+0x29/0x70 [ 1332.551844] [<ffffffff81688fc9>] schedule_timeout+0x239/0x2d0 [ 1332.551850] [<ffffffff810882f8>] ? console_unlock+0x208/0x400 [ 1332.551855] [<ffffffff810888b4>] ? vprintk_emit+0x3c4/0x510 [ 1332.551861] [<ffffffff81096acb>] ? lock_timer_base.isra.33+0x2b/0x50 [ 1332.551866] [<ffffffff8168b956>] wait_for_completion+0x116/0x170 [ 1332.551874] [<ffffffff810c4ec0>] ? wake_up_state+0x20/0x20 [ 1332.551885] [<ffffffffa06ae234>] bnx2fc_abts_cleanup+0x3d/0x62 [bnx2fc] [ 1332.551892] [<ffffffffa06a5a80>] bnx2fc_eh_abort+0x470/0x580 [bnx2fc] [ 1332.551900] [<ffffffff814570af>] scsi_error_handler+0x59f/0x8b0 [ 1332.551904] [<ffffffff81456b10>] ? scsi_eh_get_sense+0x250/0x250 [ 1332.551911] [<ffffffff810b052f>] kthread+0xcf/0xe0 [ 1332.551916] [<ffffffff810b0460>] ? kthread_create_on_node+0x140/0x140 [ 1332.551923] [<ffffffff81696418>] ret_from_fork+0x58/0x90 [ 1332.551928] [<ffffffff810b0460>] ? kthread_create_on_node+0x140/0x140 To be honest, I'm reluctant to merge these patches on bnx2fc as the I/O path on this driver has been stable for quite some time and given that it's an older driver I'm not looking to make changes there.
