Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Colin King <colin.king@xxxxxxxxxxxxx>
Subject: Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 08 May 2017 22:18:00 -0400
Cc: "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20170503162901.3623-1-colin.king@canonical.com> (Colin King's message of "Wed, 3 May 2017 17:29:01 +0100")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Colin,

> The 2nd check to see if request_size is less than zero is redundant
> because the first check takes error exit path on this condition. So,
> since it is redundant, remove it.

Applied to 4.12/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero
  - From: Colin King

Prev by Date: Re: [PATCH] scsi: lpfc: ensure els_wq is being checked before destroying it
Next by Date: Re: [PATCH] scsi: qedf: properly update arguments position in function call
Previous by thread: Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero
Next by thread: [PATCH v2] Avoid that scsi_exit_rq() triggers a use-after-free
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux