Re: [patch 17/19] st.c: Improve sense output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 7 Jul 2006, akpm@xxxxxxxx wrote:

> From: Luben Tuikov <ltuikov@xxxxxxxxx>
> 
> Convert this:
> st0: Error with sense data: <6>st: Current: sense key: Illegal Request
>     Additional sense: Invalid field in cdb
> 
> To this:
> st0: Current: sense key: Illegal Request
>     Additional sense: Invalid field in cdb
> 
> Signed-off-by: Luben Tuikov <ltuikov@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

Acked-by: Kai Makisara <kai.makisara@xxxxxxxxxxx>

> ---
> 
>  drivers/scsi/st.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff -puN drivers/scsi/st.c~stc-improve-sense-output drivers/scsi/st.c
> --- a/drivers/scsi/st.c~stc-improve-sense-output
> +++ a/drivers/scsi/st.c
> @@ -368,7 +368,7 @@ static int st_chk_result(struct scsi_tap
>  		       SRpnt->cmd[0], SRpnt->cmd[1], SRpnt->cmd[2],
>  		       SRpnt->cmd[3], SRpnt->cmd[4], SRpnt->cmd[5]);
>  		if (cmdstatp->have_sense)
> -			 __scsi_print_sense("st", SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
> +			 __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
>  	} ) /* end DEB */
>  	if (!debugging) { /* Abnormal conditions for tape */
>  		if (!cmdstatp->have_sense)
> @@ -384,9 +384,8 @@ static int st_chk_result(struct scsi_tap
>  			 scode != VOLUME_OVERFLOW &&
>  			 SRpnt->cmd[0] != MODE_SENSE &&
>  			 SRpnt->cmd[0] != TEST_UNIT_READY) {
> -				printk(KERN_WARNING "%s: Error with sense data: ", name);
> -				__scsi_print_sense("st", SRpnt->sense,
> -						   SCSI_SENSE_BUFFERSIZE);
> +
> +			__scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
>  		}
>  	}
>  
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux