> -----Original Message----- > From: Bart Van Assche [mailto:Bart.VanAssche@xxxxxxxxxxx] > Sent: Tuesday, April 25, 2017 3:08 PM > To: hch@xxxxxxxxxxxxx; Viswas G <viswas.g@xxxxxxxxxxxxx>; Gerry > Morong <gerry.morong@xxxxxxxxxxxxx>; Mahesh Rajashekhara > <mahesh.rajashekhara@xxxxxxxxxxxxx>; POSWALD@xxxxxxxx; Scott > Benesh <scott.benesh@xxxxxxxxxxxxx>; Don Brace > <don.brace@xxxxxxxxxxxxx>; Bader Ali - Saleh > <bader.alisaleh@xxxxxxxxxxxxx>; Kevin Barnett > <kevin.barnett@xxxxxxxxxxxxx>; joseph.szczypek@xxxxxxx; Scott Teel > <scott.teel@xxxxxxxxxxxxx>; jejb@xxxxxxxxxxxxxxxxxx; Justin Lindley > <justin.lindley@xxxxxxxxxxxxx>; John Hall <John.Hall@xxxxxxxxxxxxx> > Cc: linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 12/37] smartpqi: change functions to inline > > EXTERNAL EMAIL > > > On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > > From: Kevin Barnett <kevin.barnett@xxxxxxx> > > > > Reviewed-by: Scott Benesh <scott.benesh@xxxxxxxxxxxxx> > > Signed-off-by: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx> > > Signed-off-by: Don Brace <don.brace@xxxxxxxxxxxxx> > > --- > > drivers/scsi/smartpqi/smartpqi_init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/scsi/smartpqi/smartpqi_init.c > b/drivers/scsi/smartpqi/smartpqi_init.c > > index 728db8f..523b730 100644 > > --- a/drivers/scsi/smartpqi/smartpqi_init.c > > +++ b/drivers/scsi/smartpqi/smartpqi_init.c > > @@ -432,7 +432,7 @@ static struct pqi_io_request *pqi_alloc_io_request( > > return io_request; > > } > > > > -static void pqi_free_io_request(struct pqi_io_request *io_request) > > +static inline void pqi_free_io_request(struct pqi_io_request *io_request) > > { > > atomic_dec(&io_request->refcount); > > } > > A patch description should not only explain what has been changed but also > why a change has been made. What is the reason that this function has been > declared inline? Why do you think that the compiler is not smart enough to > decide on its own to inline this function? > > Thanks, > > Bart. We could have given a patch description. I'll provide one. Thanks, Don Brace ESC - Smart Storage Microsemi Corporation
