On 04/28/2017 08:35 PM, Bart Van Assche wrote:
> On Fri, 2017-04-28 at 15:06 +0200, Martin Wilck wrote:
>> @@ -886,7 +883,7 @@ static bool alua_rtpg_queue(struct alua_port_group *pg,
>> force = true;
>> }
>> if (pg->rtpg_sdev == NULL) {
>> - pg->interval = 0;
>> + pg->interval = 2;
>> pg->flags |= ALUA_PG_RUN_RTPG;
>> kref_get(&pg->kref);
>> pg->rtpg_sdev = sdev;
>
> Hello Hannes and Martin,
>
> Why is .interval initialized in alua_rtpg_queue() instead of in
> alua_alloc_pg()? I think initializing it in alua_alloc_pg() would
> make more clear that .interval is constant.
>
Yes, valid point.
Will be doing so.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
