On Thu, 2017-04-27 at 21:10 +0000, Don Brace wrote: > > - > > The new worker thread duplicates code from hpsa_rescan_ctlr_worker. > > I > > find this a bit irritating. Could you maybe use just a single > > worker, > > and just check using time stamps whether the "big" heartbeat needs > > to > > be performed? > > > > Regards > > Martin > > > > -- > > Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham > > Norton > > HRB 21284 (AG Nürnberg) > > We thought about that, but we want to separate controller events > from the rescan worker. > > Both can cause a rescan to occur however for multipath we have > found that we need to respond faster than the normal scheduled rescan > interval for path fail-overs. > > Getting controller events only involves reading a register, but > the rescan worker can obtain an updated LUN list when there > is a PTRAID device present. > > However, I did refactor the patch to move common code to > a separate function. > > Would this be more acceptable? Sounds good, yes. I'd also appreciate if you'd add these additional comments to the commit message. Regards Martin -- Dr. Martin Wilck <mwilck@xxxxxxxx>, Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
