On Thu, 2017-04-27 at 16:17 +0200, Hannes Reinecke wrote:
> When setting up a target the error message:
>
> Unable to do set ##_name ALUA state on non valid tg_pt_gp ID: 0
>
> is displayed.
> Apparently concatenation doesn't work in a string; one should be using
> implicit string concatenation here.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
> ---
> drivers/target/target_core_configfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index dc654fe..1f229cc 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -2559,9 +2559,9 @@ static ssize_t target_tg_pt_gp_alua_support_##_name##_store( \
> int ret; \
> \
> if (!t->tg_pt_gp_valid_id) { \
> - pr_err("Unable to do set ##_name ALUA state on non" \
> + pr_err("Unable to do set " #_name " ALUA state on non" \
> " valid tg_pt_gp ID: %hu\n", \
> - t->tg_pt_gp_valid_id); \
> + t->tg_pt_gp_valid_id); \
> return -EINVAL; \
> } \
Hello Hannes,
The second change breaks the alignment of the backspaces which is unfortunate.
Otherwise this patch looks fine to me.
Bart. \
