Hi,
Thanks for your review.
> yes, this makes it more readable, but i am not sure why we will have to type cast UFSHCD_STATUS_READY macro to u32 type? i think it is redundant, let me know if you think otherwise.
Sorry, nothing really.
I'll resend without u32 cast in short (i.e. change to below).
return !((reg & UFSHCD_STATUS_READY) == UFSHCD_STATUS_READY);
2017-04-26 19:49 GMT+03:00 Subhash Jadavani <subhashj@xxxxxxxxxxxxxx>:
> On 2017-04-20 05:01, kusumi.tomohiro@xxxxxxxxx wrote:
>>
>> From: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
>>
>> It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code.
>>
>> Signed-off-by: Tomohiro Kusumi <tkusumi@xxxxxxxxxx>
>> ---
>> drivers/scsi/ufs/ufshcd.c | 11 +----------
>> drivers/scsi/ufs/ufshci.h | 4 ++++
>> 2 files changed, 5 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index 9278666..ad9532b 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -668,16 +668,7 @@ static inline void
>> ufshcd_outstanding_req_clear(struct ufs_hba *hba, int tag)
>> */
>> static inline int ufshcd_get_lists_status(u32 reg)
>> {
>> - /*
>> - * The mask 0xFF is for the following HCS register bits
>> - * Bit Description
>> - * 0 Device Present
>> - * 1 UTRLRDY
>> - * 2 UTMRLRDY
>> - * 3 UCRDY
>> - * 4-7 reserved
>> - */
>> - return ((reg & 0xFF) >> 1) ^ 0x07;
>> + return !((reg & UFSHCD_STATUS_READY) == (u32)UFSHCD_STATUS_READY);
>
>
> yes, this makes it more readable, but i am not sure why we will have to type
> cast UFSHCD_STATUS_READY macro to u32 type? i think it is redundant, let me
> know if you think otherwise.
>
>> }
>>
>> /**
>> diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
>> index d14e9b9..8cd4f0e 100644
>> --- a/drivers/scsi/ufs/ufshci.h
>> +++ b/drivers/scsi/ufs/ufshci.h
>> @@ -159,6 +159,10 @@ enum {
>> #define DEVICE_ERROR_INDICATOR UFS_BIT(5)
>> #define UIC_POWER_MODE_CHANGE_REQ_STATUS_MASK UFS_MASK(0x7, 8)
>>
>> +#define UFSHCD_STATUS_READY (UTP_TRANSFER_REQ_LIST_READY |\
>> + UTP_TASK_REQ_LIST_READY |\
>> + UIC_COMMAND_READY)
>> +
>> enum {
>> PWR_OK = 0x0,
>> PWR_LOCAL = 0x01,
>
>
> --
> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
