Bart,
On 4/22/17 03:41, Bart Van Assche wrote:
> On Fri, 2017-04-21 at 18:16 +0900, damien.lemoal@xxxxxxx wrote:
>> @@ -1884,8 +1886,6 @@ static int sd_done(struct scsi_cmnd *SCpnt)
>> else {
>> sdkp->device->no_write_same = 1;
>> sd_config_write_same(sdkp);
>> -
>> - good_bytes = 0;
>> req->__data_len = blk_rq_bytes(req);
>> req->rq_flags |= RQF_QUIET;
>> }
>
> This change looks fine to me but has not been described in the patch
> description? Anyway:
>
> Reviewed-by: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>
Oops. Yes, I forgot to mention that in the commit message.
(for result != 0, good_bytes is already set to 0, so that assignment is
not necessary).
Will resend.
--
Damien Le Moal, Ph.D.
Sr. Manager, System Software Research Group,
Western Digital Corporation
Damien.LeMoal@xxxxxxx
(+81) 0466-98-3593 (ext. 513593)
1 kirihara-cho, Fujisawa,
Kanagawa, 252-0888 Japan
www.wdc.com, www.hgst.com
