Re: [PATCH 9/9] sd_zbc: Do not write lock zones for reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-04-21 at 18:16 +0900, damien.lemoal@xxxxxxx wrote:
> @@ -250,11 +249,6 @@ int sd_zbc_setup_reset_cmnd(struct scsi_cmnd *cmd)
>  		/* Unaligned request */
>  		return BLKPREP_KILL;
>  
> -	/* Do not allow concurrent reset and writes */
> -	if (sdkp->zones_wlock &&
> -	    test_and_set_bit(zno, sdkp->zones_wlock))
> -		return BLKPREP_DEFER;
> -

Hello Damien,

Since concurrent zone resets and writes are easy to detect and since these
indicate a bug in the application that submits these, should an error message
be logged if that happens? Otherwise this patch looks fine to me.

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux