Re: [PATCH 6/9] scsi: Improve scsi_get_sense_info_fld

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-04-21 at 18:16 +0900, damien.lemoal@xxxxxxx wrote:
> @@ -2363,42 +2365,32 @@ EXPORT_SYMBOL(scsi_command_normalize_sense);
>   * Return value:
>   *	1 if information field found, 0 if not found.
>   */
> -int scsi_get_sense_info_fld(const u8 * sense_buffer, int sb_len,
> -			    u64 * info_out)
> +bool scsi_get_sense_info_fld(const u8 * sense_buffer, int sb_len,
> +			     u64 * info_out)

Hello Damien,

If you have to repost this patch please address the checkpatch complaints
of the following category triggered by the above declaration:

ERROR: "foo * bar" should be "foo *bar"

Otherwise this patch looks fine to me. Hence:

Reviewed-by: Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx>






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux