> From: Guilherme G. Piccoli [mailto:gpiccoli@xxxxxxxxxxxxxxxxxx] > Sent: Thursday, April 06, 2017 3:12 PM > To: dl-esc-Aacraid Linux Driver <aacraid@xxxxxxxxxxxxx> > Cc: gpiccoli@xxxxxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; Raghava Aditya > Renukunta <RaghavaAditya.Renukunta@xxxxxxxxxxxxx> > Subject: [PATCH] scsi: aacraid: fix PCI error recovery path > > > During a PCI error recovery, if aac_check_health() is not aware that a PCI error > happened and we have an offline PCI channel, it might trigger some errors (like > NULL pointer dereference) and inhibit the error recovery process to complete. > > This patch makes the health check procedure aware of PCI channel issues, and in > case of error recovery process, the function > aac_adapter_check_health() returns -1 and let the recovery process to complete > successfully. This patch was tested on upstream kernel > v4.11-rc5 in PowerPC ppc64le architecture with adapter 9005:028d > (VID:DID) - the error recovery procedure was able to recover fine. > > Fixes: 5c63f7f710bd ("aacraid: Added EEH support") > Cc: stable@xxxxxxxxxxxxxxx # v4.6+ > Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxxxxxxxxxx> > --- Reviewed-by: Dave Carroll <david.carroll@xxxxxxxxxxxxx>