On 04/05/2017 12:16 PM, Christoph Hellwig wrote: > On Wed, Apr 05, 2017 at 12:06:53PM -0600, Jens Axboe wrote: >> On Wed, Apr 05 2017, Christoph Hellwig wrote: >>> This series fixes a few lose bits in terms of how nvme uses ->retries, >>> including fixing it for non-PCIe transports. While at it I noticed that >>> nvme and scsi use the field in entirely different ways, and no other >>> driver uses it at all. So I decided to move it into the nvme_request and >>> scsi_request structures instead. >>> >>> Changes since V1: >>> - better changelog for one patch >>> - move the new retries field to the end of struct nvme_request >> >> Applied for 4.12. If we do the below on my box, we remove the (now) 2 >> holes from struct request and shrink it 8 bytes. > > Looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks, added that too. -- Jens Axboe
