On Apr 3, 2017, at 3:46 PM, Chet L <chetanloke@xxxxxxxxx> wrote: > > On Mon, Apr 3, 2017 at 6:30 AM, Kyle Fortin <kyle.fortin@xxxxxxxxxx> wrote: > >> >> for (i = 0; i < q->max; i++) >> kfree(q->pool[i]); >> - kfree(q->pool); >> + if (q->is_pool_vmalloc) > > you could do something like: > > if (is_vmalloc_addr(q->pool)) > vfree(...); > else > kfree(..); > > And then remove the bool. > > Chetan Using linux-mmots.git which includes the new kvmalloc api, this patch is greatly simplified to a 2 character change (‘v’ x 2) of using kvmalloc / kvfree for the iscsi_pool allocation. When kvmalloc is accepted into mainline and makes it into scsi.git, then I’ll post the v2 patch using that. -- Kyle Fortin - Oracle Linux Engineering
