Re: [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sagi Grimberg <sagi@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>, Stephen Bates <sbates@xxxxxxxxxxxx>, Max Gurtovoy <maxg@xxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region
From: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Date: Tue, 4 Apr 2017 09:56:48 -0600
Cc: linux-pci@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-nvdimm@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <f269d9e1-8dcf-7970-382e-cb0d9a020efc@grimberg.me>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0


On 04/04/17 04:42 AM, Sagi Grimberg wrote:
> This is weird, why even call this if !use_p2pmem?

I personally find it cleaner than:

if (use_p2pmem)
	setup_memwin_p2pmem(...)

I'm not sure why that's so weird.

Logan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory
  - From: Logan Gunthorpe
- [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region
  - From: Logan Gunthorpe
- Re: [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region
  - From: Sagi Grimberg

Prev by Date: Re: [RFC 6/8] nvmet: Be careful about using iomem accesses when dealing with p2pmem
Next by Date: Re: [RFC PATCH 0/2] block,scsi: support host-wide tagset
Previous by thread: Re: [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region
Next by thread: RE: [RFC 2/8] cxgb4: setup pcie memory window 4 and create p2pmem region
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]