Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 27 Mar 2017 21:54:48 -0400
Cc: Boaz Harrosh <ooo@xxxxxxxxxxxxxxx>, Benny Halevy <bhalevy@xxxxxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, osd-dev@xxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20170323104142.GD20154@mwanda> (Dan Carpenter's message of "Thu, 23 Mar 2017 13:41:42 +0300")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:

> We don't call the remove() function unless probe() succeeds so "oud"
> can't be NULL here.  Plus, if it were NULL, we dereference it on the
> next line so it would crash anyway.

Applied to 4.12/scsi-queue (by hand).

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: osd_uld: remove an unneeded NULL check
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling
Next by Date: Re: [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments
Previous by thread: Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check
Next by thread: [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux