> > On Mon, Nov 07, 2016 at 07:27:38PM +0000, Winkler, Tomas wrote: > > I value your opinion but I'm not responsible for inventing RPMB > > and/or its implementation storage devices (eMMC, UFC, NVMe), it's pretty > much done deal out there in the wild. > > I'm just trying to provide common API above it. Somehow I've missed that answer, now I got back when search for comments before I'll post a new series. > And the common API must go through the SCSI midlayer. I've actually tried to do a midlayer, but I found it's too UFS specific, so there is no point to this abstraction. As not all needed data are accessible via scsi calls. The solution I propose fits with what is done in eMMC (emmc specific IOCTL). There is already some code that breaks that layering in ufshcd_set_dev_pwr_mode when talking to the special sdev_ufs. Maybe I need more hint for the correct directions. If it can't we won't > support it, so please drop the UFS patches from the series. If you have more constructive comments, I'll be glad to hear and address. Thanks Tomas
